Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update protobuf dependency to the version that fixes memory leaks. #28365

Merged
merged 2 commits into from
Sep 12, 2023

Conversation

tvalentyn
Copy link
Contributor

@tvalentyn tvalentyn commented Sep 7, 2023

Update protobuf version to a newer version that fixes some memory leaks.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Copy link

@chleech chleech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LFG

@tvalentyn tvalentyn marked this pull request as ready for review September 7, 2023 23:02
@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Merging #28365 (0335981) into master (7ba4fa9) will decrease coverage by 0.03%.
Report is 44 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #28365      +/-   ##
==========================================
- Coverage   72.36%   72.33%   -0.03%     
==========================================
  Files         681      681              
  Lines      100364   100364              
==========================================
- Hits        72624    72598      -26     
- Misses      26165    26192      +27     
+ Partials     1575     1574       -1     
Flag Coverage Δ
python 82.90% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
sdks/python/setup.py 0.00% <ø> (ø)

... and 13 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @damccorm for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tvalentyn
Copy link
Contributor Author

Unfrotunately most recent version of protbuf is still leaking memory, will follow up with protobuf team.

@tvalentyn tvalentyn closed this Sep 9, 2023
@tvalentyn tvalentyn reopened this Sep 12, 2023
@tvalentyn
Copy link
Contributor Author

It might not fix #28246 yet but we should still upgrade since this version fixes two other known issues: protocolbuffers/protobuf#10088, https://github.com/protocolbuffers/upb/issues/1243 .

@tvalentyn tvalentyn merged commit 1f9febe into apache:master Sep 12, 2023
160 checks passed
@tvalentyn tvalentyn deleted the protbuf branch September 12, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants