Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Go SDK]: Retrieve element type from input PCollection in parquetio.Write #28491

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

johannaojeling
Copy link
Contributor

Removes the t reflect.Type parameter from parquetio.Write and derives the element type from the input PCollection instead. Fixes #28490.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@codecov
Copy link

codecov bot commented Sep 16, 2023

Codecov Report

Merging #28491 (f9c5a71) into master (52abb14) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #28491      +/-   ##
==========================================
- Coverage   72.23%   72.23%   -0.01%     
==========================================
  Files         684      684              
  Lines      100855   100856       +1     
==========================================
- Hits        72854    72851       -3     
- Misses      26422    26428       +6     
+ Partials     1579     1577       -2     
Flag Coverage Δ
go 53.42% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
sdks/go/pkg/beam/io/parquetio/parquetio.go 68.65% <100.00%> (+0.47%) ⬆️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @lostluck for label go.
R: @johnjcasey for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Contributor

@lostluck lostluck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I don't love backwards incompatible changes, but this is an improvement.

@lostluck lostluck merged commit 8c7e8b0 into apache:master Sep 18, 2023
7 checks passed
@johannaojeling johannaojeling deleted the parquetio-write-type branch September 18, 2023 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task][Go SDK]: Remove reflect.Type parameter in parquetio.Write
2 participants