-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically switch to upload_graph when the graph is large #28621
Conversation
I plan to manually test this later (might add one integration test). So no need to merge this now. Thanks. |
Tested these changes internally. The test passed. |
R: @Abacn |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
Let us get a test externally. It should be very easy - just a single small test method with a big graph. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the integration test, /runners/google-cloud-dataflow-java/src/test could be a choice to settle these tests. Although currently there is only unit tests, this path is added to the integration test class path:
googleCloudPlatformIntegrationTest project(project.path) |
...oogle-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowRunner.java
Outdated
Show resolved
Hide resolved
Added one unit test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except it isn't really a breaking change.
...e-cloud-dataflow-java/src/test/java/org/apache/beam/runners/dataflow/DataflowRunnerTest.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! the code changes LGTM. Had a comment about CHANGES.md item
...e-cloud-dataflow-java/src/test/java/org/apache/beam/runners/dataflow/DataflowRunnerTest.java
Outdated
Show resolved
Hide resolved
Once it is green again (for the record) will merge. Or any committer can merge. |
Run Java PreCommit |
1 similar comment
Run Java PreCommit |
Note |
Yes this is unrelated. Tracking bug: #28957 caused by #28513 there is a pending PR include a fix: #29041 (comment) |
I think it is OK to disable the test or even better to roll back the change so we do not have untested stuff in the codebase. |
Now the job graph is larger than 10 MB, it will be automatically uploaded by enabling
upload_graph
for Java SDK.Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.