-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new resource hint to all sdks for number of cpus per worker machine #28848
Conversation
Codecov Report
@@ Coverage Diff @@
## master #28848 +/- ##
==========================================
- Coverage 72.23% 72.15% -0.09%
==========================================
Files 684 686 +2
Lines 101198 101613 +415
==========================================
+ Hits 73102 73317 +215
- Misses 26518 26716 +198
- Partials 1578 1580 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 28 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Assigning reviewers. If you would like to opt out of this review, comment R: @AnandInguva for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!! Python changes look good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, LGTM from java side. Just had a minor comment about documentation
model/pipeline/src/main/proto/org/apache/beam/model/pipeline/v1/beam_runner_api.proto
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from the Go side
there are format errors, for java, run for python, lint error not related to this PR |
There is go test error:
|
LGTM for the Updated Go code, if we get the Go Tests precommit to pass. |
it appears go test is failing on master However the first a few red run was not go change. EDIT: actually this is an long standing flaky test, opened #28951 |
Run Java_PVR_Flink_Batch PreCommit |
Run Java PreCommit |
java precommit timeout due to #28957 not related - merging for now |
…ne (apache#28848) * Adds new resource hint for number of cpus per worker. * Fixes minor bugs.` * Go fmt and removes unwanted .python-version file. * Adds tests. * Fixes typo. * Fixes Java tests, adds URN to parsers. * Addresses FindBugs issue with int parsing. * Applies Java formatting corrections * Adds generated go protobufs
This resource hint allows for further specifcation of user needs at the transfor or pipeline level.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.