Run examples on Java21 #28969

Abacn · 2023-10-12T20:23:06Z

Part of #28967 ; fixes #23695

along with other cleanup on examples and java version handling

upgrade gradle 8.3 -> 8.4 which is needed for compiling and run tests with Java21
Use temurin 21 base image as its available now
Setup a few Java21 postcommits
Fix kotlin test
Fix javaVersion to be 1.8/11/17/21

Note that Java Dataflow runner v1 pending on internal java21 dev container release so not included in this PR

Please add a meaningful description for your change here

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
Update CHANGES.md with noteworthy changes.
If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Abacn · 2023-10-12T20:26:08Z

.github/workflows/beam_PostCommit_Java_Examples_Dataflow_V2_Java.yml

@@ -77,7 +77,9 @@ jobs:
        uses: actions/setup-java@v3.8.0
        with:
          distribution: 'temurin'
-          java-version: ${{ matrix.java_version }}
+          java-version: |


previous setting was not quite what we want. We want beam (java core, runners) compile with Java8 and test compile and run with Java11/17/21.

However, we do want the example jar to be compiled on Java11/17/21, see #28967 as followups

codecov · 2023-10-12T21:13:38Z

Codecov Report

Merging #28969 (6580b53) into master (683fbd6) will not change coverage.
Report is 5 commits behind head on master.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #28969   +/-   ##
=======================================
  Coverage   38.37%   38.37%           
=======================================
  Files         686      686           
  Lines      101685   101685           
=======================================
  Hits        39018    39018           
  Misses      61087    61087           
  Partials     1580     1580

Flag	Coverage Δ
python	`29.98% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

github-actions · 2023-10-12T21:35:00Z

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

* upgrade gradle 8,3 -> 8.4 * Use temurin 21 base image as its available now * Setup Java21 JPMS postcommits * Setup Java21 Example PostCommit on DataflowV2 * Fix kotlin test

Abacn · 2023-10-23T20:58:35Z

Tested by equivalent gradle command

Java Examples

./gradlew :runners:google-cloud-dataflow-java:examplesJavaRunnerV2IntegrationTest -PdisableSpotlessCheck=true -PdisableCheckStyle=true -PskipCheckerFramework -PtestJavaVersion=21 -Pjava21Home=.../.sdkman/candidates/java/21-zulu

jobId: 2023-10-23_13_51_50-1524320457990904336 2023-10-23_13_51_48-3336529009400839971 2023-10-23_13_51_48-540232565689758221 2023-10-23_13_51_48-7689190307853488284 in project apache-beam-testing

all have "userAgent Apache_Beam_SDK_for_Java/2.52.0-SNAPSHOT(JRE_21_environment)" and passed

JPMS

./gradlew :sdks:java:testing:jpms-test:directRunnerIntegrationTest -PskipCheckerFramework -PtestJavaVersion=21 -Pjava21Home=.../.sdkman/candidates/java/21-zulu

Abacn · 2023-10-24T13:34:39Z

assign set of reviewers

github-actions · 2023-10-24T13:36:00Z

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @robertwb for label java.
R: @damccorm for label build.

Available commands:

stop reviewer notifications - opt out of the automated review tooling
remind me after tests pass - tag the comment author after tests pass
waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

damccorm

Thanks - LGTM

Abacn · 2023-10-24T14:13:04Z

Run Java_PVR_Flink_Batch PreCommit

github-actions bot added java build examples docker kotlin labels Oct 12, 2023

Abacn commented Oct 12, 2023

View reviewed changes

Abacn force-pushed the java21tumerin branch 3 times, most recently from 001693c to f67cfa7 Compare October 12, 2023 20:44

Abacn changed the title ~~Run examples on Java21~~ [WIP] Run examples on Java21 Oct 13, 2023

Abacn marked this pull request as draft October 13, 2023 14:19

Abacn mentioned this pull request Oct 13, 2023

Setup Java 21 container #28918

Merged

3 tasks

Abacn force-pushed the java21tumerin branch 2 times, most recently from 5444d5c to f226b33 Compare October 23, 2023 20:28

Enable run test on Java 21

6580b53

* upgrade gradle 8,3 -> 8.4 * Use temurin 21 base image as its available now * Setup Java21 JPMS postcommits * Setup Java21 Example PostCommit on DataflowV2 * Fix kotlin test

Abacn force-pushed the java21tumerin branch from f226b33 to 6580b53 Compare October 23, 2023 20:42

Abacn changed the title ~~[WIP] Run examples on Java21~~ Run examples on Java21 Oct 23, 2023

Abacn marked this pull request as ready for review October 23, 2023 20:58

github-actions bot added the Next Action: Reviewers label Oct 24, 2023

damccorm approved these changes Oct 24, 2023

View reviewed changes

Abacn merged commit bc06581 into apache:master Oct 24, 2023
33 checks passed

Abacn deleted the java21tumerin branch October 24, 2023 15:05

Abacn mentioned this pull request Oct 24, 2023

Fixes Java Examples ARM GHA on Java8 #29117

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Run examples on Java21 #28969

Run examples on Java21 #28969

Abacn commented Oct 12, 2023 •

edited

Loading

Abacn Oct 12, 2023

Abacn Oct 23, 2023 •

edited

Loading

codecov bot commented Oct 12, 2023 •

edited

Loading

github-actions bot commented Oct 12, 2023

Abacn commented Oct 23, 2023

Abacn commented Oct 24, 2023

github-actions bot commented Oct 24, 2023

damccorm left a comment

Abacn commented Oct 24, 2023

Run examples on Java21 #28969

Run examples on Java21 #28969

Conversation

Abacn commented Oct 12, 2023 • edited Loading

GitHub Actions Tests Status (on master branch)

Abacn Oct 12, 2023

Choose a reason for hiding this comment

Abacn Oct 23, 2023 • edited Loading

Choose a reason for hiding this comment

codecov bot commented Oct 12, 2023 • edited Loading

Codecov Report

github-actions bot commented Oct 12, 2023

Abacn commented Oct 23, 2023

Java Examples

JPMS

Abacn commented Oct 24, 2023

github-actions bot commented Oct 24, 2023

damccorm left a comment

Choose a reason for hiding this comment

Abacn commented Oct 24, 2023

Abacn commented Oct 12, 2023 •

edited

Loading

Abacn Oct 23, 2023 •

edited

Loading

codecov bot commented Oct 12, 2023 •

edited

Loading