Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#23893] Support composite scope transform metadata #29204

Merged
merged 8 commits into from
Nov 2, 2023

Conversation

lostluck
Copy link
Contributor

@lostluck lostluck commented Oct 30, 2023

  • Adds PTransform annotation plumbing through context.Context
    • Lays groundwork to do the same for PTransform Display Data.
  • Deferred to another PR: Doing the same for environments.
    • Punted from this PR since it's a much broader change to install.

Working on #23893.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions bot added the go label Oct 30, 2023
@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Merging #29204 (fdb601f) into master (2f8eebb) will increase coverage by 0.01%.
Report is 61 commits behind head on master.
The diff coverage is 68.96%.

@@            Coverage Diff             @@
##           master   #29204      +/-   ##
==========================================
+ Coverage   38.36%   38.38%   +0.01%     
==========================================
  Files         687      688       +1     
  Lines      101747   101804      +57     
==========================================
+ Hits        39039    39078      +39     
- Misses      61129    61143      +14     
- Partials     1579     1583       +4     
Flag Coverage Δ
go 53.45% <68.96%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
sdks/go/pkg/beam/core/graph/graph.go 60.65% <100.00%> (ø)
sdks/go/pkg/beam/core/graph/scope.go 0.00% <ø> (ø)
sdks/go/pkg/beam/core/runtime/graphx/translate.go 37.61% <100.00%> (+0.48%) ⬆️
sdks/go/pkg/beam/pipeline.go 45.83% <0.00%> (-9.17%) ⬇️
.../go/pkg/beam/core/runtime/contextreg/contextreg.go 68.18% <68.18%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lostluck lostluck marked this pull request as ready for review November 1, 2023 18:48
Copy link
Contributor

github-actions bot commented Nov 1, 2023

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @riteshghorse for label go.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@lostluck lostluck changed the title [#23893] Support composite scope resource hints and annotation. [#23893] Support composite scope transform metadata Nov 1, 2023
Copy link
Contributor

@riteshghorse riteshghorse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@lostluck lostluck merged commit edbeda7 into apache:master Nov 2, 2023
@lostluck
Copy link
Contributor Author

lostluck commented Nov 2, 2023

Thanks for the review!

@lostluck lostluck deleted the beam23893 branch November 2, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants