ActiveWorkRefresh

[m-trieu]

StreamingDataflowWorker is a very large class. This breaks out the active work refresh and invalidating commit logic ( async work management) to another class.

Initial implementation is what currently exists today. There will be another implementation of refreshActiveWork() later for direct path, but this PR lays the ground work for it. Also add tests to have more coverage over individual components than just the StreamingDataflowWorkerTest which is larger.

R: @arunpandianp

---

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

• Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
• Update CHANGES.md with noteworthy changes.
• If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

[github-actions]

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @riteshghorse added as fallback since no labels match configuration

Available commands:

• stop reviewer notifications - opt out of the automated review tooling
• remind me after tests pass - tag the comment author after tests pass
• waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

[riteshghorse]

R: @arunpandianp

[github-actions]

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

[arunpandianp]

Can we send a fake clock and control the passage of time instead of relying on sleeping?

[Abacn]

There is a flaky test (#28957 (comment)):

testInvalidateStuckCommits: https://github.com/apache/beam/runs/22276370706

Wanted but not invoked:
forComputation.invalidate(
    <ByteString@3e931ad0 size=0 contents="">,
    0L
);
-> at org.apache.beam.runners.dataflow.worker.windmill.work.refresh.DispatchedActiveWorkRefresherTest.testInvalidateStuckCommits(DispatchedActiveWorkRefresherTest.java:231)
Actually, there were zero interactions with this mock.

	at org.apache.beam.runners.dataflow.worker.windmill.work.refresh.DispatchedActiveWorkRefresherTest.testInvalidateStuckCommits(DispatchedActiveWorkRefresherTest.java:231)

[m-trieu]

I will take a look and fix thanks @Abacn !