Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable BigQueryMetrics by default #31015

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Enable BigQueryMetrics by default #31015

merged 1 commit into from
Apr 30, 2024

Conversation

JayajP
Copy link
Contributor

@JayajP JayajP commented Apr 17, 2024

New BigQuery Metrics will be auto-enabled after this change. Metrics can be disabled for a pipeline by passing the experiment disable_per_worker_metrics.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@JayajP
Copy link
Contributor Author

JayajP commented Apr 17, 2024

Run Java Precommit

@JayajP JayajP marked this pull request as ready for review April 17, 2024 16:37
Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

Copy link
Contributor

@Abacn Abacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, the change LGTM. Would you mind note this change in CHANGES.md ?

personally since the logics were just merged today. I would prefer flipping the flag in the next release cycle (2.57.0), taking more time to test.

@Abacn Abacn merged commit 4a134b5 into apache:master Apr 30, 2024
16 checks passed
@Abacn
Copy link
Contributor

Abacn commented Apr 30, 2024

@JayajP merged, would you mind open a new PR to announce (promote) this change in CHANGES.md ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants