Move lint, yapf, whitespace and dependency compat tests to from py38 to py39 #31195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvalentyn
commented
May 6, 2024
| @@ -81,7 +81,7 @@ jobs: | |||
| uses: ./.github/actions/setup-environment-action | |||
| with: | |||
| java-version: 8 | |||
| python-version: 3.8 | |||
| python-version: 3.9 | |||
There was a problem hiding this comment.
It seems that GHA runner is not picking up this change, even though this branch is created against the apache repo.
There was a problem hiding this comment.
2024-05-06T19:16:59.5735995Z > Task :sdks:python:test-suites:tox:py39:setupVirtualenv FAILED
2024-05-06T19:16:59.5737272Z sh: 1: python3.9: not found
2024-05-06T19:17:04.4734316Z
2024-05-06T19:17:04.4736168Z > Task :sdks:python:setupVirtualenv
2024-05-06T19:17:04.7734906Z Requirement already satisfied: pip in /runner/_work/beam/beam/build/gradleenv/1922375555/lib/python3.8/site-packages (23.0.1)
There was a problem hiding this comment.
From https://github.com/apache/beam/actions/runs/8974464687/job/24646903804?pr=31195 : looks like the runner still installs Py38.
Run actions/setup-python@v4
with:
python-version: 3.8
check-latest: false
token: ***
update-environment: true
allow-prereleases: false
env:
GRADLE_ENTERPRISE_ACCESS_KEY: ***
GRADLE_ENTERPRISE_CACHE_USERNAME: ***
GRADLE_ENTERPRISE_CACHE_PASSWORD: ***
KUBELET_GCLOUD_CONFIG_PATH: /var/lib/kubelet/pods/44b5be43-a1ff-431b-886f-5083466a6efc/volumes/kubernetes.io~empty-dir/gcloud
There was a problem hiding this comment.
Trying a manual run: https://github.com/apache/beam/actions/runs/8974817049
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the python version for linter, yapf, whitespace PostCommit_Python_Dependency.yml and PreCommit_Python_Coverage.yml to use Python 3.9.
part of #31192 to unblock #31185 .
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.