Update Build Wheels to only build once on RCs #32009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
damccorm
reviewed
Jul 29, 2024
| working-directory: apache-beam-source/wheelhouse/ | ||
| run: | | ||
| for file in *.whl; do | ||
| sha512sum $file > ${file}.sha512 | ||
| done | ||
| shell: bash | ||
| - name: Upload wheels as artifacts | ||
| if: ${{ needs.build_source.outputs.is_rc == 0 }} |
There was a problem hiding this comment.
This does have one downside: if people are building their own beam version using this wheel, they won't get any cherry picks to the release branch.
I think that is fine though, and this seems worth it
jrmccluskey
added a commit
to jrmccluskey/beam
that referenced
this pull request
Jul 29, 2024
3 tasks
damccorm
pushed a commit
that referenced
this pull request
Jul 29, 2024
jrmccluskey
added a commit
that referenced
this pull request
Jul 29, 2024
This reverts commit ffae5b5.
jrmccluskey
added a commit
that referenced
this pull request
Jul 29, 2024
jrmccluskey
added a commit
that referenced
this pull request
Jul 29, 2024
damccorm
pushed a commit
that referenced
this pull request
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When run for RCs, the workflow builds the wheels from source as well as the RC tag, doubling the run time for the workflow and running into timeouts on self-hosted runners. This change mirrors the RC logic and should only execute the source wheel build when invoked against non-RCs
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.