Support ordered list states in python sdk and fnapi runner #32326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shunping
changed the title
shunping
changed the title
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
shunping
commented
Sep 24, 2024
robertwb
reviewed
Oct 1, 2024
sdks/python/apache_beam/runners/portability/fn_api_runner/worker_handlers.py
Outdated
Show resolved
Hide resolved
sdks/python/apache_beam/runners/portability/fn_api_runner/worker_handlers.py
Outdated
Show resolved
Hide resolved
sdks/python/apache_beam/runners/portability/fn_api_runner/worker_handlers.py
Outdated
Show resolved
Hide resolved
sdks/python/apache_beam/runners/portability/fn_api_runner/worker_handlers.py
Outdated
Show resolved
Hide resolved
sdks/python/apache_beam/runners/portability/fn_api_runner/worker_handlers.py
Outdated
Show resolved
Hide resolved
shunping
force-pushed
the
ordered-list-state-python
branch
from
1ac6690
to
f870c21
Compare
|
@robertwb Could you please take another look? Thanks! |
robertwb
reviewed
Oct 8, 2024
sdks/python/apache_beam/runners/portability/fn_api_runner/worker_handlers.py
Outdated
Show resolved
Hide resolved
robertwb
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up PR of #30317, where we support ordered list state in java sdk.
Here we implement ordered list state for python sdk. We also add the support of ordered list state into Python FnApi runner for debug and testing purpose.