Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force kafka 3.1.2 for expansion-service jar #32703

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

Polber
Copy link
Contributor

@Polber Polber commented Oct 8, 2024

#32623 was intended to package kafka-clients 3.1.2 into the expansion-service JAR, but gradle favors versions specified in groovy plugin module, so the version was being overridden with 2.4.1. This PR forces 3.1.2 to be used during runtime.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Signed-off-by: Jeffrey Kinard <jeff@thekinards.com>
@Polber
Copy link
Contributor Author

Polber commented Oct 8, 2024

R: @Abacn

Copy link
Contributor

github-actions bot commented Oct 8, 2024

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@Abacn Abacn merged commit c4b4170 into apache:master Oct 8, 2024
24 checks passed
@Abacn
Copy link
Contributor

Abacn commented Oct 8, 2024

Thanks! would you mind opening a chery-pick PR?

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.85%. Comparing base (d4dd58b) to head (5d7ab61).
Report is 22 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #32703      +/-   ##
============================================
- Coverage     58.85%   58.85%   -0.01%     
  Complexity     3091     3091              
============================================
  Files          1130     1130              
  Lines        174108   174105       -3     
  Branches       3312     3312              
============================================
- Hits         102465   102462       -3     
  Misses        68317    68317              
  Partials       3326     3326              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Abacn pushed a commit to Abacn/beam that referenced this pull request Oct 8, 2024
Signed-off-by: Jeffrey Kinard <jeff@thekinards.com>
damccorm pushed a commit that referenced this pull request Oct 9, 2024
Signed-off-by: Jeffrey Kinard <jeff@thekinards.com>
Co-authored-by: Jeff Kinard <jeff@thekinards.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants