-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sdks/python: enable named aggregation to deferred DataFrame groupby #33672
sdks/python: enable named aggregation to deferred DataFrame groupby #33672
Conversation
6e1a075
to
eaede37
Compare
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
eaede37
to
b4b17f7
Compare
Run Prism_Python PreCommit 3.9 |
Assigning reviewers. If you would like to opt out of this review, comment R: @tvalentyn for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Reminder, please take a look at this pr: @tvalentyn |
b4b17f7
to
7fde445
Compare
In this commit, we enable named aggregated to deferred DataFrame groupby operation.
In this commit, we test named aggregation to deferred DataFrame groupby operation by passing None as function and passing multiple kwargs aggregation functions on testing columns.
7fde445
to
721f18e
Compare
Thanks for the change and follow-up, @mohamedawnallah . For future changes, please don't squash reviewed and unreviewed commits before the review process has concluded; instead, add follow-up commits on the branch, leaving prior commits as is. Otherwise, reviewing is significantly harder. |
I will keep this in mind next time, Thanks 🙏
Thanks for your patience @tvalentyn 🙏 |
…pache#33672) * sdks/python: enable named aggregation In this commit, we enable named aggregated to deferred DataFrame groupby operation. * sdks/python: test named aggregation In this commit, we test named aggregation to deferred DataFrame groupby operation by passing None as function and passing multiple kwargs aggregation functions on testing columns.
Description
In this commit, we enable named aggregation to deferred DataFrame groupby.
Fixes #27278
Current Behavior
Verifying Named Aggregation in Beam DataFrame GroupBy
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.