[Dataflow Streaming] Reduce contention on work submission #33687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
R: @scwhittle |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
scwhittle
requested changes
Jan 21, 2025
.../worker/src/main/java/org/apache/beam/runners/dataflow/worker/util/BoundedQueueExecutor.java
Outdated
Show resolved
Hide resolved
.../worker/src/main/java/org/apache/beam/runners/dataflow/worker/util/BoundedQueueExecutor.java
Outdated
Show resolved
Hide resolved
.../worker/src/main/java/org/apache/beam/runners/dataflow/worker/util/BoundedQueueExecutor.java
Show resolved
Hide resolved
|
Run Java PreCommit |
scwhittle
requested changes
Jan 23, 2025
.../worker/src/main/java/org/apache/beam/runners/dataflow/worker/util/BoundedQueueExecutor.java
Show resolved
Hide resolved
scwhittle
requested changes
Jan 24, 2025
.../worker/src/main/java/org/apache/beam/runners/dataflow/worker/util/BoundedQueueExecutor.java
Outdated
Show resolved
Hide resolved
.../worker/src/main/java/org/apache/beam/runners/dataflow/worker/util/BoundedQueueExecutor.java
Outdated
Show resolved
Hide resolved
scwhittle
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The monitor guarding BoundedQueueExecutor's counters was locked by both the work submitting threads and the harness threads (300 of them). The contention can slow down the work submission loop. This change reduces the contention by collapsing counter updates from the harness threads and letting one thread to lock the monitor and update the counters.
Example wallz profile showing the stacks locking the monitor
#33578