-
Notifications
You must be signed in to change notification settings - Fork 4.5k
use avro 1.12.0 #34970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use avro 1.12.0 #34970
Conversation
|
Assigning reviewers: R: @Abacn for label build. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Abacn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may want to add 1.11.3 here for avro compatibility test
| def avroVersions = [ |
Abacn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
|
Looks like Avro 1.12 dropped Java 8 support:
after this change https://github.com/apache/beam/actions/workflows/beam_PreCommit_Java_Spark3_Versions.yml started failing due to test cannot be compiled on Java8 |
|
The test can be fixed by #34985. However we may still need to rollback this change as it effectively dropped Beam Java 8 support. Alternatively one can pin avro version as
|
#34969 does not work since 1.11.4 does not have the test jar. Try 1.12.0
Fixes #34968
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.