-
Notifications
You must be signed in to change notification settings - Fork 4.5k
force avro 1.11.4 for the expansion service #34994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #34994 +/- ##
============================================
+ Coverage 54.50% 56.45% +1.95%
- Complexity 1479 3300 +1821
============================================
Files 1012 1184 +172
Lines 160667 181767 +21100
Branches 1079 3409 +2330
============================================
+ Hits 87573 102624 +15051
- Misses 70991 75873 +4882
- Partials 2103 3270 +1167
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
We need to pin them in schemaio-expansion service and gcp-expansion service also, As they are all packed into the expansion service container: https://github.com/apache/beam/blob/master/sdks/java/expansion-service/container/build.gradle#L39-L41 |
Good point. Updated more builds |
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
|
Assigning reviewers: R: @chamikaramj for label java. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
* force avro 1.11.4 for the expansion service * added resolutionStrategy.force for other expansion services
fixes #34968 with the workaround only for expansion service.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.