Skip to content

Conversation

@liferoad
Copy link
Contributor

fixes #34968 with the workaround only for expansion service.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@codecov
Copy link

codecov bot commented May 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.45%. Comparing base (bea0444) to head (e8a3b35).
Report is 5 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #34994      +/-   ##
============================================
+ Coverage     54.50%   56.45%   +1.95%     
- Complexity     1479     3300    +1821     
============================================
  Files          1012     1184     +172     
  Lines        160667   181767   +21100     
  Branches       1079     3409    +2330     
============================================
+ Hits          87573   102624   +15051     
- Misses        70991    75873    +4882     
- Partials       2103     3270    +1167     
Flag Coverage Δ
java 70.58% <ø> (+1.93%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@liferoad liferoad marked this pull request as ready for review May 19, 2025 17:03
@liferoad liferoad requested a review from Abacn May 19, 2025 17:03
@Abacn
Copy link
Contributor

Abacn commented May 19, 2025

We need to pin them in schemaio-expansion service and gcp-expansion service also, As they are all packed into the expansion service container: https://github.com/apache/beam/blob/master/sdks/java/expansion-service/container/build.gradle#L39-L41

@liferoad
Copy link
Contributor Author

We need to pin them in schemaio-expansion service and gcp-expansion service also, As they are all packed into the expansion service container: https://github.com/apache/beam/blob/master/sdks/java/expansion-service/container/build.gradle#L39-L41

Good point. Updated more builds

@github-actions
Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@github-actions
Copy link
Contributor

Assigning reviewers:

R: @chamikaramj for label java.
R: @Abacn for label build.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@liferoad liferoad merged commit b287985 into apache:master May 19, 2025
30 checks passed
changliiu pushed a commit to changliiu/beam that referenced this pull request May 22, 2025
* force avro 1.11.4 for the expansion service

* added resolutionStrategy.force for other expansion services
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Task]: Google Cloud Platform Expansion Service contains CVE-2024-47561

2 participants