Skip to content

Conversation

@A1K28
Copy link
Contributor

@A1K28 A1K28 commented Aug 20, 2025

Increase GRPC timeouts and force sequential execution for increased stability. you can see successful runs here: https://github.com/A1K28/beam/actions/workflows/beam_PreCommit_Python.yml

fixes #34739


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@A1K28
Copy link
Contributor Author

A1K28 commented Aug 20, 2025

@Amar3tto

@github-actions github-actions bot added the build label Aug 20, 2025
@A1K28 A1K28 marked this pull request as ready for review August 20, 2025 09:45
@A1K28
Copy link
Contributor Author

A1K28 commented Aug 20, 2025

R: @damccorm

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@Amar3tto Amar3tto requested review from Abacn and damccorm August 20, 2025 17:24
Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Had one question, but doesn't need to block merging

Comment on lines +67 to +69
BEAM_RETRY_MAX_ATTEMPTS: "5"
BEAM_RETRY_INITIAL_DELAY_MS: "5000"
BEAM_RETRY_MAX_DELAY_MS: "120000"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do these Beam-specific config settings impact things? I can't see where they are used

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My apologies, I was supposed to implement these in the code. I will fix this in the next PR. Currently, you are right, they don't do anything, since i didn't write necessary code for it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem - I was guessing that was the case; since we merged it we'll be able to see the impact in any PR workflow runs which is nice anyways

@damccorm damccorm merged commit 6910486 into apache:master Aug 21, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The PreCommit Python job is flaky

2 participants