Skip to content

Remove bad session test from SpannerReadIT #36009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Abacn merged 2 commits into from
Aug 29, 2025
Merged

Remove bad session test from SpannerReadIT #36009

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
52d42a0
Remove bad session test from SpannerReadIT
shreyakhajanchi Aug 29, 2025
2f44d93
fixing spotless
shreyakhajanchi Aug 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 0 additions & 55 deletions ...google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/spanner/SpannerReadIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
import static org.junit.Assert.assertEquals;

import com.google.api.gax.longrunning.OperationFuture;
import com.google.cloud.spanner.BatchClient;
import com.google.cloud.spanner.Database;
import com.google.cloud.spanner.DatabaseAdminClient;
import com.google.cloud.spanner.DatabaseClient;
Expand All @@ -45,12 +44,8 @@
import org.apache.beam.sdk.testing.TestPipeline;
import org.apache.beam.sdk.testing.TestPipelineOptions;
import org.apache.beam.sdk.transforms.Count;
import org.apache.beam.sdk.transforms.Create;
import org.apache.beam.sdk.transforms.MapElements;
import org.apache.beam.sdk.transforms.ParDo;
import org.apache.beam.sdk.transforms.SerializableFunction;
import org.apache.beam.sdk.transforms.SimpleFunction;
import org.apache.beam.sdk.transforms.View;
import org.apache.beam.sdk.values.PCollection;
import org.apache.beam.sdk.values.PCollectionView;
import org.apache.beam.sdk.values.TypeDescriptor;
Expand All @@ -70,7 +65,6 @@
public class SpannerReadIT {

private static final int MAX_DB_NAME_LENGTH = 30;
private static final int CLEANUP_PROPAGATION_DELAY_MS = 5000;

@Rule public final transient TestPipeline p = TestPipeline.create();
@Rule public transient ExpectedException thrown = ExpectedException.none();
Expand Down Expand Up @@ -275,55 +269,6 @@ public void testReadFailsBadTable() throws Exception {
p.run().waitUntilFinish();
}

private static class CloseTransactionFn extends SimpleFunction<Transaction, Transaction> {
private final SpannerConfig spannerConfig;

private CloseTransactionFn(SpannerConfig spannerConfig) {
this.spannerConfig = spannerConfig;
}

@Override
public Transaction apply(Transaction tx) {
BatchClient batchClient = SpannerAccessor.getOrCreate(spannerConfig).getBatchClient();
batchClient.batchReadOnlyTransaction(tx.transactionId()).cleanup();
try {
// Wait for cleanup to propagate.
Thread.sleep(CLEANUP_PROPAGATION_DELAY_MS);
} catch (InterruptedException e) {
Thread.currentThread().interrupt();
}
return tx;
}
}

@Test
public void testReadFailsBadSession() throws Exception {

thrown.expect(new SpannerWriteIT.StackTraceContainsString("SpannerException"));
thrown.expect(new SpannerWriteIT.StackTraceContainsString("NOT_FOUND: Session not found"));

SpannerConfig spannerConfig = createSpannerConfig();

// This creates a transaction then closes the session.
// The (closed) transaction is then passed to SpannerIO.read() and should
// raise SessionNotFound errors.
PCollectionView<Transaction> tx =
p.apply("Transaction seed", Create.of(1))
.apply(
"Create transaction",
ParDo.of(new CreateTransactionFn(spannerConfig, TimestampBound.strong())))
.apply("Close Transaction", MapElements.via(new CloseTransactionFn(spannerConfig)))
.apply("As PCollectionView", View.asSingleton());
p.apply(
"read db",
SpannerIO.read()
.withSpannerConfig(spannerConfig)
.withTable(options.getTable())
.withColumns("Key", "Value")
.withTransaction(tx));
p.run().waitUntilFinish();
}

@Test
public void testQuery() throws Exception {
SpannerConfig spannerConfig = createSpannerConfig();
Expand Down
Loading