Skip to content

Conversation

@tarun-google
Copy link
Contributor

@tarun-google tarun-google commented Sep 19, 2025

Fixes #33074

Part-1: Check customGcsTempLocation value provider wrapping a null location. This is happening in Managed FileLoads path. While the next solution is to fix from client. This is part-1 fixes the BigQueryIO to be more robust in checking the null wrapped ValueProvider. We can add a stricter check that validates the value of customGcsTempLocation before hand. But we need to evaluate more paths and fix the client first.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@tarun-google tarun-google marked this pull request as ready for review September 19, 2025 15:57
@github-actions
Copy link
Contributor

Assigning reviewers:

R: @m-trieu for label java.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@tarun-google
Copy link
Contributor Author

R: @chamikaramj @ahmedabu98

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

Copy link
Contributor

@ahmedabu98 ahmedabu98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ahmedabu98 ahmedabu98 merged commit cf55fee into apache:master Sep 22, 2025
15 checks passed
@Abacn
Copy link
Contributor

Abacn commented Oct 20, 2025

valueProvider.get() check at pipeline submission time may not work: GoogleCloudPlatform/DataflowTemplates#2892 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Cross-language pipeline options are not picked up in Java DoFns

3 participants