Skip to content

Conversation

@Amar3tto
Copy link
Collaborator

@Amar3tto Amar3tto commented Oct 10, 2025

Fixes #35847
Successful run: https://github.com/apache/beam/actions/runs/18399714463/job/52425961883

Related issue: #33753


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Amar3tto, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue affecting Python LoadTests for CoGBK Flink Batch jobs by enhancing the logging mechanism within the PrismLogHandler. The core change involves updating how logging levels are interpreted, enabling the system to correctly process log levels that include numerical offsets. This ensures accurate categorization and display of log messages, which is crucial for debugging and monitoring the performance of these batch jobs.

Highlights

  • Logging Level Parsing: The PrismLogHandler now correctly parses logging levels that include numerical offsets (e.g., 'ERROR+2', 'WARNING-1'), allowing for more granular control over log severity.
  • Regular Expression Import: The re module has been imported to facilitate the parsing of complex logging level strings.
Ignored Files
  • Ignored by pattern: .github/workflows/** (5)
    • .github/workflows/beam_LoadTests_Python_CoGBK_Flink_Batch.yml
    • .github/workflows/beam_Publish_Docker_Snapshots.yml
    • .github/workflows/load-tests-pipeline-options/python_CoGBK_Flink_Batch_100b_Multiple_Keys.txt
    • .github/workflows/load-tests-pipeline-options/python_CoGBK_Flink_Batch_100b_Single_Key.txt
    • .github/workflows/load-tests-pipeline-options/python_CoGBK_Flink_Batch_10kB.txt
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions
Copy link
Contributor

Assigning reviewers:

R: @claudevdm for label python.
R: @Abacn for label build.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

-PpythonVersion=3.9 \
-PloadTest.mainClass=apache_beam.testing.load_tests.co_group_by_key_test \
-Prunner=FlinkRunner \
-Prunner=PortableRunner \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if we do this, we're defeating the point of the tests - the goal here is to test against the flink runner

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PortableRunner should be correct one, see other workflows: https://github.com/apache/beam/blob/590ece2cd8e586d063686ce4cae86bc7da5a319a/.github/workflows/beam_LoadTests_Python_Combine_Flink_Batch.yml these tests work by setting up a DataProc cluster and a portable runner endpoint that map to DataProc, then submit Beam pipelines to the portable runner endpoint.

The question is why it runs on direct runner previously when setting this parameter to "FlinkRunner"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, it's because the .txt pipeline option files did not specify runner type

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, it's because the .txt pipeline option files did not specify runner type

Yes, correct

@Amar3tto Amar3tto merged commit 62df216 into master Oct 10, 2025
133 of 138 checks passed
@Amar3tto Amar3tto deleted the fix-flink-cogbk branch October 23, 2025 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The LoadTests Python CoGBK Flink Batch job is flaky

3 participants