-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Fix LoadTests Python CoGBK Flink Batch job #36472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @Amar3tto, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves an issue affecting Python LoadTests for CoGBK Flink Batch jobs by enhancing the logging mechanism within the Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
2908f98 to
590ece2
Compare
|
Assigning reviewers: R: @claudevdm for label python. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
| -PpythonVersion=3.9 \ | ||
| -PloadTest.mainClass=apache_beam.testing.load_tests.co_group_by_key_test \ | ||
| -Prunner=FlinkRunner \ | ||
| -Prunner=PortableRunner \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think if we do this, we're defeating the point of the tests - the goal here is to test against the flink runner
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PortableRunner should be correct one, see other workflows: https://github.com/apache/beam/blob/590ece2cd8e586d063686ce4cae86bc7da5a319a/.github/workflows/beam_LoadTests_Python_Combine_Flink_Batch.yml these tests work by setting up a DataProc cluster and a portable runner endpoint that map to DataProc, then submit Beam pipelines to the portable runner endpoint.
The question is why it runs on direct runner previously when setting this parameter to "FlinkRunner"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, it's because the .txt pipeline option files did not specify runner type
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, it's because the .txt pipeline option files did not specify runner type
Yes, correct
Fixes #35847
Successful run: https://github.com/apache/beam/actions/runs/18399714463/job/52425961883
Related issue: #33753
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.