fix jsonToRowTest race condition #36616
Conversation
|
Run Java PreCommit |
1 similar comment
|
Run Java PreCommit |
|
Assigning reviewers: R: @m-trieu for label java. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
| * DoFn.setup. This avoids a data race caused by modifying the global default settings. | ||
| */ | ||
| public static JsonFactory createJsonFactory(int sizeLimit) { | ||
| public static synchronized JsonFactory createJsonFactory(int sizeLimit) { |
There was a problem hiding this comment.
Shall we confine synchronize {} block only around StreamReadConstraintsHelper.setStreamReadConstraints?
| public static synchronized void increaseDefaultStreamReadConstraints(int newLimit) { | ||
| if (newLimit > defaultBufferLimit) { | ||
| try { | ||
| Class.forName("com.fasterxml.jackson.core.StreamReadConstraints"); |
There was a problem hiding this comment.
we can check STREAM_READ_CONSTRAINTS_AVAILABLE then return early and remove this try {} block
|
Run Java_GCP_IO_Direct PreCommit |
|
Run Java PreCommit |
|
testParDoRequiresStableInputPortable (org.apache.beam.runners.flink.FlinkRequiresStableInputTest) failed testWriteAggregatedWithMaxBytes (org.apache.beam.sdk.io.aws2.kinesis.KinesisIOWriteTest) failed both not related to the change, merging for now |
2 participants
Race condition still present after supposedly fixing it - #36073
b/453202934
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.