Skip to content

Conversation

@damccorm
Copy link
Contributor

@damccorm damccorm commented Oct 31, 2025

These are only used by files which already have associated extras (gcp, yaml, interactive), so there's no reason to bundle them into the main installable

Part of #34554


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@damccorm damccorm changed the title Split some dependencies out of main beam package into gcp Split some dependencies out of main beam package into existing extras Oct 31, 2025
@codecov
Copy link

codecov bot commented Oct 31, 2025

Codecov Report

❌ Patch coverage is 55.55556% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 36.24%. Comparing base (fe07fe7) to head (ef5e2c9).
⚠️ Report is 12 commits behind head on master.

Files with missing lines Patch % Lines
...beam/runners/interactive/display/pipeline_graph.py 50.00% 2 Missing ⚠️
sdks/python/apache_beam/yaml/json_utils.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #36697      +/-   ##
============================================
- Coverage     36.25%   36.24%   -0.01%     
  Complexity     1666     1666              
============================================
  Files          1059     1060       +1     
  Lines        165727   165830     +103     
  Branches       1195     1195              
============================================
+ Hits          60077    60110      +33     
- Misses       103478   103548      +70     
  Partials       2172     2172              
Flag Coverage Δ
python 40.51% <55.55%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@damccorm damccorm marked this pull request as ready for review November 3, 2025 17:02
@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2025

Assigning reviewers:

R: @tvalentyn for label python.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@damccorm damccorm merged commit 3a1ae18 into master Nov 3, 2025
132 of 135 checks passed
@damccorm damccorm deleted the users/damccorm/gcp-setup-split branch November 3, 2025 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants