Skip to content

Bigtable: clean up client side metrics flag #37596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mutianf wants to merge 1 commit into
base: master
Choose a base branch
from
+0 −13
Open

Bigtable: clean up client side metrics flag #37596

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions ...ud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableServiceFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,6 @@ class BigtableServiceFactory implements Serializable {
private static final ConcurrentHashMap<UUID, AtomicInteger> refCounts = new ConcurrentHashMap<>();
private static final Object lock = new Object();

private static final String BIGTABLE_ENABLE_CLIENT_SIDE_METRICS =
"bigtable_enable_client_side_metrics";

private static final String BIGTABLE_ENABLE_SKIP_LARGE_ROWS = "bigtable_enable_skip_large_rows";

@AutoValue
Expand Down Expand Up @@ -130,11 +127,6 @@ BigtableServiceEntry getServiceForReading(
BigtableConfigTranslator.translateReadToVeneerSettings(
config, opts, optsFromBigtableOptions, pipelineOptions);

if (ExperimentalOptions.hasExperiment(pipelineOptions, BIGTABLE_ENABLE_CLIENT_SIDE_METRICS)) {
LOG.info("Enabling client side metrics");
BigtableDataSettings.enableBuiltinMetrics();
}

boolean skipLargeRows =
ExperimentalOptions.hasExperiment(pipelineOptions, BIGTABLE_ENABLE_SKIP_LARGE_ROWS);

Expand Down Expand Up @@ -181,11 +173,6 @@ BigtableServiceEntry getServiceForWriting(
BigtableConfigTranslator.translateWriteToVeneerSettings(
config, opts, optsFromBigtableOptions, pipelineOptions);

if (ExperimentalOptions.hasExperiment(pipelineOptions, BIGTABLE_ENABLE_CLIENT_SIDE_METRICS)) {
LOG.info("Enabling client side metrics");
BigtableDataSettings.enableBuiltinMetrics();
}

BigtableService service = new BigtableServiceImpl(settings);
entry = BigtableServiceEntry.create(configId, service);
entries.put(configId.id(), entry);
Expand Down
Loading