Skip to content

[Dataflow Streaming] Add post submit test for dataflow streaming with windmill tag encoding v2#37603

Open
arunpandianp wants to merge 1 commit intoapache:masterfrom
arunpandianp:postsubmitv2
Open

[Dataflow Streaming] Add post submit test for dataflow streaming with windmill tag encoding v2#37603
arunpandianp wants to merge 1 commit intoapache:masterfrom
arunpandianp:postsubmitv2

Conversation

@arunpandianp
Copy link
Contributor

The post submit is similar to beam_PostCommit_Java_ValidatesRunner_Dataflow_Streaming excepet that it enables streaming engine and sets the experiments to enable statetagEncodingV2

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @arunpandianp, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new post-submit test to ensure the stability and correctness of Dataflow streaming jobs when utilizing the streaming engine and state tag encoding v2. By adding a dedicated validation task and centralizing streaming test configurations, it enhances the testing infrastructure for advanced Dataflow features.

Highlights

  • New Post-Submit Test: A new post-submit test, beam_PostCommit_Java_ValidatesRunner_Dataflow_Streaming_TagEncodingV2, has been introduced to validate Dataflow streaming with specific experimental features.
  • Gradle Task for Tag Encoding V2: A new Gradle task, validatesRunnerStreamingTagEncodingV2, was added to build.gradle to run Dataflow runner validation tests with streaming engine and state tag encoding v2 experiments enabled.
  • Refactored Streaming Configuration: Common configuration for Dataflow streaming runner validation tests has been extracted into a shared validatesRunnerStreamingConfig variable in build.gradle for better reusability.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • .github/trigger_files/beam_PostCommit_Java_ValidatesRunner_Dataflow_Streaming_TagEncodingV2.json
    • Added a new trigger file to initiate the Dataflow streaming tag encoding v2 post-submit test.
  • runners/google-cloud-dataflow-java/build.gradle
    • Defined a new validatesRunnerStreamingConfig map to consolidate common streaming pipeline options and excluded tests.
    • Updated the existing validatesRunnerStreaming task to utilize the new shared configuration.
    • Introduced a new Gradle task validatesRunnerStreamingTagEncodingV2 to run tests with specific Dataflow streaming engine and state tag encoding v2 experiments enabled.
Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/beam_PostCommit_Java_ValidatesRunner_Dataflow_Streaming_TagEncodingV2.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@arunpandianp
Copy link
Contributor Author

R: @scwhittle

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant