Add HTTPS detection for ClickHouse JDBC URL parsing

[BentsiLeviav]

Summary

Enhances the JDBC URL parser to automatically detect and use HTTPS based on SSL indicators in legacy JDBC URLs, ensuring compatibility with ClickHouse Cloud and secure connections.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

• Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
• Update CHANGES.md with noteworthy changes.
• If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

[gemini-code-assist]

Summary of Changes

Hello @BentsiLeviav, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly improves the ClickHouse JDBC URL parser by introducing intelligent HTTPS detection. It allows the parser to automatically infer and enforce secure HTTPS connections based on common indicators like the port number or the presence of an SSL parameter, thereby streamlining configuration and enhancing security for ClickHouse integrations, especially with cloud environments.

Highlights

• Automatic HTTPS Detection: The JDBC URL parser now automatically detects and applies the HTTPS scheme if the URL contains ':8443' (ClickHouse's default HTTPS port) or the 'ssl=true' parameter.
• Scheme Upgrade: Existing 'http://' schemes in JDBC URLs are automatically upgraded to 'https://' if either the ':8443' port or 'ssl=true' parameter is present, ensuring secure connections.
• ClickHouse Cloud Compatibility: These changes enhance compatibility with ClickHouse Cloud, which often relies on secure HTTPS connections.
• Comprehensive Testing: New unit tests have been added to cover various scenarios, including explicit SSL parameters, default HTTPS ports, and scheme upgrades.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• sdks/java/io/clickhouse/src/main/java/org/apache/beam/sdk/io/clickhouse/ClickHouseJdbcUrlParser.java
  • Modified the extractHttpUrl method to include logic for detecting HTTPS based on port 8443 or the ssl=true parameter.
  • Implemented functionality to upgrade an http:// scheme to https:// if SSL indicators are present.
  • Updated Javadoc to reflect the new HTTPS detection capabilities.
• sdks/java/io/clickhouse/src/test/java/org/apache/beam/sdk/io/clickhouse/ClickHouseJdbcUrlParserTest.java
  • Added new test cases to verify correct HTTPS detection when port 8443 is used.
  • Included tests to confirm HTTPS is applied when ssl=true is present in the URL parameters.
  • Introduced tests for scenarios where an explicit http:// scheme is upgraded to https://.
  • Added a test case specifically for ClickHouse Cloud URL patterns.

Activity

• No human activity recorded yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[BentsiLeviav]

I added support for more edge cases to increase the backward compatibility rate.
@chamikaramj @damccorm @Abacn Sorry for the last-minute ask - but would you mind reviewing it before the 2.72.0 release candidate?

[BentsiLeviav]

CC @mzitnik

[mzitnik]

LGTM

[github-actions]

Assigning reviewers:

R: @kennknowles for label java.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

• stop reviewer notifications - opt out of the automated review tooling
• remind me after tests pass - tag the comment author after tests pass
• waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

[BentsiLeviav]

Hi @kennknowles

This PR is an extension of that one #37611.
Any chance we can get your assistance to make sure it is included in the 2.72.0 release?