Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add big_query_query_to_table_it to python SDK #6401

Merged
merged 1 commit into from
Sep 18, 2018
Merged

Add big_query_query_to_table_it to python SDK #6401

merged 1 commit into from
Sep 18, 2018

Conversation

boyuanzz
Copy link
Contributor

Add big_query_query_to_table_it to python SDK, include test cases: legacy query, standard query and new types.

@boyuanzz
Copy link
Contributor Author

Run Python PostCommit

1 similar comment
@boyuanzz
Copy link
Contributor Author

Run Python PostCommit

@boyuanzz
Copy link
Contributor Author

Run Python PostCommit

@boyuanzz
Copy link
Contributor Author

Run Python PostCommit

boyuanzz
boyuanzz commented Sep 17, 2018
View reviewed changes
sdks/python/apache_beam/io/gcp/big_query_query_to_table_it_test.py Outdated
NEW_TYPES_OUTPUT_SCHEMA = (
'{"fields": [{"name": "bytes","type": "BYTES"},'
'{"name": "date","type": "DATE"},{"name": "time","type": "TIME"}]}')
NEW_TYPES_OUTPUT_VERIFY_QUERY = ('SELECT date FROM [%s];')
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, this verify query should also query bytes and time. But there are some bugs within current bigquery client version we are using. For time, it cannot process .9999999: googleapis/google-cloud-python#5750. For bytes, it cannot query bytes type properly.

@boyuanzz
Copy link
Contributor Author

R: @pabloem
cc: @aaltay

@boyuanzz
Copy link
Contributor Author

Run Python PostCommit

@boyuanzz
Copy link
Contributor Author

Run Python PostCommit

@boyuanzz
Copy link
Contributor Author

Run Python PostCommit

1 similar comment
@boyuanzz
Copy link
Contributor Author

Run Python PostCommit

@boyuanzz
Copy link
Contributor Author

Run Python PostCommit

@boyuanzz
Copy link
Contributor Author

Run Python PostCommit

@boyuanzz
Copy link
Contributor Author

There are some other failures in PostCommit, which aren't related to my changes, eg out of quotas: https://scans.gradle.com/s/fias56tanijtc/console-log#L2358
IT succeeded with dataflow runner: https://scans.gradle.com/s/fias56tanijtc/console-log#L2353
IT succeeded with direct runner: https://scans.gradle.com/s/fias56tanijtc/console-log#L243

@pabloem
Copy link
Member

pabloem commented Sep 18, 2018

This is excellent. Thank you Boyuan.

@pabloem pabloem merged commit 5d2e2f6 into apache:master Sep 18, 2018
@boyuanzz boyuanzz deleted the python_bq_it branch October 3, 2018 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@boyuanzz @pabloem