Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task: upgrade RocksDB #4409

Open
dlg99 opened this issue May 30, 2024 · 4 comments · May be fixed by #4422
Open

Task: upgrade RocksDB #4409

dlg99 opened this issue May 30, 2024 · 4 comments · May be fixed by #4422
Labels
good first issue type/feature

Comments

@dlg99
Copy link
Contributor

dlg99 commented May 30, 2024

BK currently uses RocksDB 7.9.2.
RocksDB has a bugfix release 7.10.2 (if we decide to to do a minor upgrade for now) and 9.2.1 with variety of performance improvements and features.

We should consider upgrading; I don't know if 9.2.1 would break anything compatibility-wise, 7.10.2 should be safe.
@hangc0276
Copy link
Contributor

I think we'd better upgrade to 7.10.2 first. Due to 9.2.1 being a major version, we should double-test to see if it breaks the current behaviors.

@shoothzj
Copy link
Member

+1 for 7.10.2 first

@bhiwagade-rahul
Copy link

@dlg99 may I ask the scope of testing to do after the version change in pom file?

@dlg99 dlg99 mentioned this issue May 31, 2024
Merged
@dlg99
Copy link
Contributor Author

dlg99 commented May 31, 2024

@bhiwagade-rahul with the minor version upgrade the CI should be good enough; maybe a short perf run.
For the major version upgrade we'd want to test with Apache Pulsar, test upgrades, and do more tests under load.
Unfortunately perf/load tests are up to contributors as we can't run them on CI.

I don't remember current state of integration tests for upgrade, I vaguely remember that at some point they weren't executed?

shoothzj pushed a commit that referenced this issue Jun 3, 2024
@dlg99
Upgrade RocksDB to version 7.10.2 (#4413)
f67e370 
Main Issue: #4409

### Motivation

Upgrade RocksDB to version 7.10.2

### Changes

Upgrade RocksDB to version 7.10.2
@dlg99 dlg99 linked a pull request Jun 6, 2024 that will close this issue
Open
shoothzj pushed a commit that referenced this issue Jun 8, 2024
@dlg99 @shoothzj
Upgrade RocksDB to version 7.10.2 (#4413)
97b0827 
Main Issue: #4409

### Motivation

Upgrade RocksDB to version 7.10.2

### Changes

Upgrade RocksDB to version 7.10.2

(cherry picked from commit f67e370)
shoothzj pushed a commit that referenced this issue Jun 10, 2024
@dlg99 @shoothzj
Upgrade RocksDB to version 7.10.2 (#4413)
f087bcd 
Main Issue: #4409

### Motivation

Upgrade RocksDB to version 7.10.2

### Changes

Upgrade RocksDB to version 7.10.2
Ghatage pushed a commit to sijie/bookkeeper that referenced this issue Jul 12, 2024
@dlg99
Upgrade RocksDB to version 7.10.2 (apache#4413)
346042c 
Main Issue: apache#4409

### Motivation

Upgrade RocksDB to version 7.10.2

### Changes

Upgrade RocksDB to version 7.10.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue type/feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade RocksDB to version 9.2.1 dlg99/bookkeeper
4 participants
@bhiwagade-rahul @hangc0276 @dlg99 @shoothzj