Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: shell tests are broken and not running on CI #3251

Merged
merged 3 commits into from
Apr 29, 2022
Merged

Fix: shell tests are broken and not running on CI #3251

merged 3 commits into from
Apr 29, 2022

Conversation

dlg99
Copy link
Contributor

@dlg99 dlg99 commented Apr 28, 2022 •
edited
Loading

Descriptions of the changes in this PR:

Motivation

https://lists.apache.org/thread/mjqbtnhs506q7906008znbtf9gg1onfp

these tests don't run on "mvn test" and I suspect they don't
run on CI too.

To repro locally:
cd tests/scripts

mvn clean install -DskipTests
mvn test

-> success

mvn clean install

-> failed tests

Changes

Fixed tests, added to CI.

eolivelli
eolivelli approved these changes Apr 29, 2022
View reviewed changes
Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eolivelli eolivelli merged commit 2a75296 into apache:master Apr 29, 2022
dlg99 added a commit that referenced this pull request Apr 29, 2022
@dlg99
Fix: shell tests are broken and not running on CI (#3251)
bf93ed0 
(cherry picked from commit 2a75296)
@hangc0276 hangc0276 modified the milestones: 4.16.0, 4.15.0 Jul 25, 2022
Ghatage pushed a commit to sijie/bookkeeper that referenced this pull request Jul 12, 2024
@dlg99
Fix: shell tests are broken and not running on CI (apache#3251)
002dad6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiazhai jiazhai jiazhai approved these changes

@eolivelli eolivelli eolivelli approved these changes

@hezhangjian hezhangjian hezhangjian approved these changes

@nicoloboschi nicoloboschi nicoloboschi approved these changes

Assignees

@dlg99 dlg99

Labels
area/tests
Projects
None yet
Milestone
4.15.0
Development

Successfully merging this pull request may close these issues.
6 participants
@dlg99 @jiazhai @eolivelli @hezhangjian @nicoloboschi @hangc0276