[Branch-4.16] Downgrade grpc and protobuf to avoid introducing breaking change #4001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--- ### Motivation We upgrade grpc and protobuf to address CVE-2023-32732. But it requires the protobuf 3.22+. In protobuf 3.22.0, it introduces a breaking change. It require all the sub-project, which depends on the bookkeeper to upgrade protobuf to 3.22.0+. It should not be acceptable in a minor release. So we use a lower version of grpc and protobuf to address the CVE issue. See more context: apache#3997
|
@lhotari PTAL, thanks |
zymap
changed the title
lhotari
approved these changes
Jun 25, 2023
4 tasks
|
protocolbuffers/protobuf#11393 Another compatible issue with jdk8, I need to downgrade the protobuf to 3.21.9. |
|
LGTM |
hangc0276
changed the title
zymap
added a commit
that referenced
this pull request
Dec 7, 2023
…ng change (#4001) * Downgrade grpc to 1.54.1 --- ### Motivation We upgrade grpc and protobuf to address CVE-2023-32732. But it requires the protobuf 3.22+. In protobuf 3.22.0, it introduces a breaking change. It require all the sub-project, which depends on the bookkeeper to upgrade protobuf to 3.22.0+. It should not be acceptable in a minor release. So we use a lower version of grpc and protobuf to address the CVE issue. See more context: #3997 (cherry picked from commit 9f63cf7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We upgrade grpc and protobuf to address CVE-2023-32732. But it requires the protobuf 3.22+. In protobuf 3.22.0, it introduces a breaking change. It requires all the sub-project, which depend on the bookkeeper to upgrade protobuf to 3.22.0+. It should not be acceptable in a minor release.
So we use a lower version of grpc and protobuf to address the CVE issue.
See more context: #3997