Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Test] migrate-junit5-client-module and parameterized beforeEach #4518

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Test] migrate-junit5-client-module and parameterized beforeEach #4518

wants to merge 1 commit into from

Conversation

sherlock-lin
Copy link
Contributor

@sherlock-lin sherlock-lin commented Oct 24, 2024 •
edited
Loading

Main Issue: #4322

1. why parameterized beforeEach

Because the current version of Junit 5 does not support class-level parameterized， related links，We can achieve the same effect by beforeEach。

2. Short-term solutions(this pr)

Refer to this post custom ParameterResolver and beforeEach implementations class-level parameterized

3. Long-term solutions

Keep up with the Junit5 community, and when Junit5 supports class-level parameterized, go with the official Junit5 way!

Test results

image image

@sherlock-lin sherlock-lin force-pushed the sherlock-migrate-junit5-client-moudule-1024 branch 6 times, most recently from fb12e3c to f0e8158 Compare October 25, 2024 03:10
@sherlock-lin
Copy link
Contributor Author

@shoothzj please help review

hezhangjian
hezhangjian reviewed Oct 25, 2024
View reviewed changes
Copy link
Member

@hezhangjian hezhangjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, can we use four indents in new code of bookkeeper-server/src/test/java/org/apache/bookkeeper/client/HandleFailuresTest.java?

@sherlock-lin
Copy link
Contributor Author

Overall looks good, can we use four indents in new code of bookkeeper-server/src/test/java/org/apache/bookkeeper/client/HandleFailuresTest.java?

sure😊

@sherlock-lin sherlock-lin force-pushed the sherlock-migrate-junit5-client-moudule-1024 branch from f0e8158 to 7968110 Compare October 25, 2024 08:14
@sherlock-lin sherlock-lin force-pushed the sherlock-migrate-junit5-client-moudule-1024 branch from 7968110 to 66add87 Compare October 25, 2024 08:15
@StevenLuMT StevenLuMT closed this Feb 14, 2025
@StevenLuMT StevenLuMT reopened this Feb 14, 2025
@StevenLuMT
Copy link
Member

reopen's reason: rerun failure checks

@dlg99
Copy link
Contributor

dlg99 commented Feb 14, 2025

CI is failing:

[INFO] 
Error:  Errors: 
Error:  org.apache.bookkeeper.client.TestMaxEnsembleChangeNum.testChangeEnsembleMaxNumWithWriter
Error:    Run 1: TestMaxEnsembleChangeNum.testChangeEnsembleMaxNumWithWriter:46->MockBookKeeperTestCase.setBookKeeperConfig:253 » NullPointer
Error:    Run 2: TestMaxEnsembleChangeNum.testChangeEnsembleMaxNumWithWriter:46->MockBookKeeperTestCase.setBookKeeperConfig:253 » NullPointer
Error:    Run 3: TestMaxEnsembleChangeNum.testChangeEnsembleMaxNumWithWriter:46->MockBookKeeperTestCase.setBookKeeperConfig:253 » NullPointer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hezhangjian hezhangjian hezhangjian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sherlock-lin @StevenLuMT @dlg99 @hezhangjian