Fix region aware placement policy disk weight dose not update. #4522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dragonls
force-pushed
the
fix_region_aware_placement_policy_disk_weight_does_not_update
branch
from
da24cb8
to
f4901c7
Compare
dlg99
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We are using region aware policy in our Pulsar cluster and enable the disk weight base placement feature.
There are different CVMs with different free disk space in a region, but we found that the traffic still seems to be balanced and is not distributed according to the weight of the free disk space.
The root cause of this case is that the disk weight information actually used to allocate bookies in
RegionAwareEnsemblePlacementPolicyhas not been updated at all.The
RegionAwareEnsemblePlacementPolicyactually choose bookies for ensemble byRackawareEnsemblePlacementPolicyof each region inperRegionPlacement, seeorg.apache.bookkeeper.client.RegionAwareEnsemblePlacementPolicy#newEnsemble.RegionAwareEnsemblePlacementPolicy.updateBookieInfodose not update thebookieInfoMapinRackawareEnsemblePlacementPolicyof each region inperRegionPlacement, which results that the disk weight information actually used to allocate bookies inRegionAwareEnsemblePlacementPolicyhas not been updated at all.Changes
updateBookieInfoinRegionAwareEnsemblePlacementPolicy, update the bookie info inRackawareEnsemblePlacementPolicyof each region inperRegionPlacement.org.apache.bookkeeper.client.TestRegionAwareEnsemblePlacementPolicy#testRegionsWithDifferentDiskWeight.