fix pendingDeletedLedgers do not remove ledger error #4525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnonHxy
reviewed
Nov 15, 2024
| @@ -345,6 +345,7 @@ public void removeDeletedLedgers() throws IOException { | |||
| log.debug("Persisting deletes of ledgers {}", deletedLedgers); | |||
| } | |||
|
|
|||
| pendingDeletedLedgers.clear(); | |||
There was a problem hiding this comment.
Thanks for your fix. But I think we should call pendingDeletedLedgers.remove(ledgerId) after line342.
pendingDeletedLedgers cloud being adding when call clear(), cause some ledgers not have deleted from ledgersDB but clear from pendingDeletedLedgers .
By the way. pendingDeletedLedgers is a Sets.newConcurrentHashSet(). I think it will not concurrent error.
TakaHiR07
force-pushed
the
fix_pendingDeletedLedgers_not_remove_ledger
branch
from
495513d
to
2fc7cf0
Compare
AnonHxy
approved these changes
Nov 18, 2024
dlg99
approved these changes
Nov 18, 2024
shoothzj
reviewed
Nov 19, 2024
you can see the new code |
shoothzj
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
fix this pr #3989 cause ledger not remove in pendingDeletedLedgers.
Previous would do poll(), but later just do forEach()
Changes
keep the same logic before pr-3989.
Alternative fix is revert previous pr.