[Suggestion] Merge guide/dev into website/developers #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahgittin
reviewed
Jun 20, 2017
| @@ -1,14 +1,21 @@ | |||
| --- | |||
| layout: website-normal | |||
| title: Developers | |||
| started-pdf-exclude: true | |||
There was a problem hiding this comment.
think this might be required for PDF build?
ahgittin
reviewed
Jun 20, 2017
| @@ -65,6 +65,8 @@ JAVA_DEBUG_OPTS='-agentlib:jdwp=transport=dt_socket,server=y,suspend=y,address=5 | |||
| For other options please check your JVM JPDA documentation. | |||
| Hotspot JPDA: https://docs.oracle.com/javase/8/docs/technotes/guides/jpda/ | |||
|
|
|||
| ## Quick testing | |||
There was a problem hiding this comment.
Either this should have content or next section should be a subsection (### not ##)
|
Do not merge yet. In addition to the comments the case for making this change needs to be made. The reason for the old docs structure is that some of the dev guide content is specific to a given version. We lose that clarity with this PR. I expect @bostko is suggesting that precision is not worth the user-facing complexity, but @bostko it would be helpful to describe how this is simpler and note main places confusion could arise if we don't have the dev guide aligned for released versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One section for all coding related matters.