Fix baidu master service leak (#2717)

apache · Jul 29, 2024 · 455310a · 455310a
1 parent fc56be6
commit 455310a
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/src/brpc/server.cpp b/src/brpc/server.cpp
@@ -443,6 +443,9 @@ Server::~Server() {
     _options.thrift_service = NULL;
 #endif
 
+    delete _options.baidu_master_service;
+    _options.baidu_master_service = NULL;
+
     delete _options.http_master_service;
     _options.http_master_service = NULL;
 

diff --git a/src/brpc/server.h b/src/brpc/server.h
@@ -226,6 +226,13 @@ struct ServerOptions {
     // Default: false
     bool use_rdma;
 
+    // [CAUTION] This option is for implementing specialized baidu-std proxies,
+    // most users don't need it. Don't change this option unless you fully
+    // understand the description below.
+    // If this option is set, all baidu-std requests to the server will be delegated
+    // to this service.
+    //
+    // Owned by Server and deleted in server's destructor.
     BaiduMasterService* baidu_master_service;
 
     // [CAUTION] This option is for implementing specialized http proxies,