reduce sampler's mutex scope #1200
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I7e413acedc8dfb93eae5c08243f0ff3e484f7059
|
@zyearn 辛苦看下这个？理论分析上看是没有风险的 |
jamesge
reviewed
Nov 18, 2020
| if (!s->_used) { | ||
| s->_mutex.unlock(); | ||
| if (s->_used.load(butil::memory_order_acquire)) { | ||
| BAIDU_SCOPED_LOCK(s->_mutex); |
| _mutex.lock(); | ||
| _used = false; | ||
| _mutex.unlock(); | ||
| _used.store(false, butil::memory_order_release); |
There was a problem hiding this comment.
需要在注释里举一个场景说明一下为什么要release语意
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: I7e413acedc8dfb93eae5c08243f0ff3e484f7059
问题: 线上环境中，进程退出时，hang在sampler->destroy()中的_mutex lock上，持有该_mutex的线程已经不再使用该锁且在正常运行，没有分析出发生路径
改动原因: _used变量无需_mutex保护，减少_mutex的范围来规避该问题。同时stop变量跨越了线程，需要atomic