-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make brpc support GCC 4.4.7, tested on Ubuntu 12.04 LTS. #17
Conversation
atomic and memory order is not fully supported before gcc4.8(checkout https://gcc.gnu.org/gcc-4.7/cxx0x_status.html). It's unsafe since memory order matters in brpc, You'd better try boost::atomic (which the internal version of brpc really uses), instead of using std::atomic. |
@chenzhangyi People all say that but nobody gives why. Does GCC under 4.8 have bugs on atomic and memory order? Is there any document or bug reporting marks that? |
The link given by @chenzhangyi clearly states memory order is not supported in gcc4.4, so this patch will not be merged. However brpc can be built with gcc 3.4 and 4.4 inside Baidu, with deps on boost.atomic. It shouldn't be too hard to mimic that on this opensourced version. You can have another PR or fire an issue. |
You guys are really arrogant. |
This patch makes example/echo_c++ work on Ubuntu 12.04 with GCC 4.4.7.