Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make brpc support GCC 4.4.7, tested on Ubuntu 12.04 LTS. #17

Closed
wants to merge 1 commit into from

Conversation

solrex
Copy link

@solrex solrex commented Sep 18, 2017

This patch makes example/echo_c++ work on Ubuntu 12.04 with GCC 4.4.7.

@chenzhangyi
Copy link
Member

atomic and memory order is not fully supported before gcc4.8(checkout https://gcc.gnu.org/gcc-4.7/cxx0x_status.html). It's unsafe since memory order matters in brpc, You'd better try boost::atomic (which the internal version of brpc really uses), instead of using std::atomic.

@solrex
Copy link
Author

solrex commented Sep 18, 2017

@chenzhangyi People all say that but nobody gives why. Does GCC under 4.8 have bugs on atomic and memory order? Is there any document or bug reporting marks that?

@jamesge
Copy link
Contributor

jamesge commented Sep 18, 2017

The link given by @chenzhangyi clearly states memory order is not supported in gcc4.4, so this patch will not be merged. However brpc can be built with gcc 3.4 and 4.4 inside Baidu, with deps on boost.atomic. It shouldn't be too hard to mimic that on this opensourced version. You can have another PR or fire an issue.

@jamesge jamesge closed this Sep 18, 2017
@solrex
Copy link
Author

solrex commented Sep 19, 2017

You guys are really arrogant.

@wzw921026 wzw921026 mentioned this pull request Jan 21, 2019
@zgb40302 zgb40302 mentioned this pull request Dec 5, 2019
@yqynju yqynju mentioned this pull request Jul 16, 2021
@xiedeacc xiedeacc mentioned this pull request Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants