Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

redis auth support select db #1768

Merged
merged 3 commits into from
Jul 19, 2022
Merged

redis auth support select db #1768

merged 3 commits into from
Jul 19, 2022

Conversation

zwkno1
Copy link
Contributor

@zwkno1 zwkno1 commented May 27, 2022

在redis auth中支持select db

@zwkno1 zwkno1 mentioned this pull request May 27, 2022
Closed
@wwbmmm
Copy link
Contributor

wwbmmm commented Jun 6, 2022

  1. 这个PR把with_auth强行从bool改成int，看起来太难受了。要么改个名字（比如auth_count），要么加个flag（比如with_selectdb）。
  2. 改了3个ppt文件，是改了什么内容呢？

@zwkno1
Copy link
Contributor Author

zwkno1 commented Jun 6, 2022

  1. 这个PR把with_auth强行从bool改成int，看起来太难受了。要么改个名字（比如auth_count），要么加个flag（比如with_selectdb）。
  2. 改了3个ppt文件，是改了什么内容呢？

改了个名 auth_flags, doc下ppt的都恢复了

wwbmmm
wwbmmm requested changes Jun 7, 2022
View reviewed changes
src/brpc/controller.h Outdated Show resolved Hide resolved
src/brpc/details/controller_private_accessor.h Outdated Show resolved Hide resolved
@zwkno1 zwkno1 requested a review from wwbmmm June 14, 2022 04:26
@zwkno1
Copy link
Contributor Author

zwkno1 commented Jul 4, 2022

大哥，这玩意还能不能合了

@wwbmmm
Copy link
Contributor

wwbmmm commented Jul 5, 2022 •
edited
Loading

LGTM
@lorinlee 有空也看看

@lorinlee lorinlee self-requested a review July 8, 2022 02:28
@lorinlee lorinlee merged commit 53cbd1a into apache:master Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Huixxi Huixxi Huixxi left review comments

@wwbmmm wwbmmm wwbmmm approved these changes

@lorinlee lorinlee Awaiting requested review from lorinlee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zwkno1 @wwbmmm @Huixxi @lorinlee