Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fall back to libibverbs.so.1 #1985

Merged
merged 1 commit into from
Nov 10, 2022
Merged

Fall back to libibverbs.so.1 #1985

merged 1 commit into from
Nov 10, 2022

Conversation

372046933
Copy link
Contributor

What problem does this PR solve?

Issue Number:

Problem Summary:

What is changed and the side effects?

Changed:

Side effects:

  • Performance effects(性能影响):

  • Breaking backward compatibility(向后兼容性):


Check List:

  • Please make sure your changes are compilable(请确保你的更改可以通过编译).
  • When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
  • Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

libibverbs.so is provided by libibverbs-dev and it is a symbol link to libibverbs.so.1 which is provided by libibverbs1.
We do not need -dev package in production environment. So linking to libibverbs.so.1 is a better solution.

lrwxrwxrwx 1 root root   15 Jan 28  2022 /usr/lib/x86_64-linux-gnu/libibverbs.so -> libibverbs.so.1
lrwxrwxrwx 1 root root   23 Jan 28  2022 /usr/lib/x86_64-linux-gnu/libibverbs.so.1 -> libibverbs.so.1.14.39.0
-rw-r--r-- 1 root root 139K Jan 28  2022 /usr/lib/x86_64-linux-gnu/libibverbs.so.1.14.39.0

Here is NCCL usage
https://github.com/NVIDIA/nccl/blob/2f4cb874ba461f67adbd78b6f19fc5bc7c458ab7/src/misc/ibvwrap.cc#L52-L59

Other differs on rdma.md is necessary to enable RDMA on libbrpc

@wwbmmm wwbmmm merged commit 2a00420 into apache:master Nov 10, 2022
@372046933 372046933 deleted the fallback_to_libibverbs.so.1 branch November 10, 2022 09:32
@Tuvie
Copy link
Contributor

Tuvie commented Nov 10, 2022

Could you please share how you install libibverbs? At all my servers, libibverbs.so and libibverbs.so.1 exist at the same time and the former one is a symbol link to the latter one. The latter one is also a symbol link to the real so, just like the figure you pasted above.

@372046933
Copy link
Contributor Author

Could you please share how you install libibverbs? At all my servers, libibverbs.so and libibverbs.so.1 exist at the same time and the former one is a symbol link to the latter one. The latter one is also a symbol link to the real so, just like the figure you pasted above.

On Ubuntu 22.04 , libibverbs1 provides libibverbs.so.1 and the real so.

# dpkg -L libibverbs1
/.
/usr
/usr/lib
/usr/lib/x86_64-linux-gnu
/usr/lib/x86_64-linux-gnu/libibverbs.so.1.14.39.0
/usr/share
/usr/share/doc
/usr/share/doc/libibverbs1
/usr/share/doc/libibverbs1/changelog.Debian.gz
/usr/share/doc/libibverbs1/copyright
/usr/share/doc/libibverbs1/libibverbs.md
/usr/lib/x86_64-linux-gnu/libibverbs.so.1

This is enough to use ibverbs in production environment(libibverbs-dev is not necessary).
In development environment, libibverbs-dev provides header files and libibverbs.so as a symbol link.

@Tuvie
Copy link
Contributor

Tuvie commented Nov 13, 2022

Could you please share how you install libibverbs? At all my servers, libibverbs.so and libibverbs.so.1 exist at the same time and the former one is a symbol link to the latter one. The latter one is also a symbol link to the real so, just like the figure you pasted above.

On Ubuntu 22.04 , libibverbs1 provides libibverbs.so.1 and the real so.

# dpkg -L libibverbs1
/.
/usr
/usr/lib
/usr/lib/x86_64-linux-gnu
/usr/lib/x86_64-linux-gnu/libibverbs.so.1.14.39.0
/usr/share
/usr/share/doc
/usr/share/doc/libibverbs1
/usr/share/doc/libibverbs1/changelog.Debian.gz
/usr/share/doc/libibverbs1/copyright
/usr/share/doc/libibverbs1/libibverbs.md
/usr/lib/x86_64-linux-gnu/libibverbs.so.1

This is enough to use ibverbs in production environment(libibverbs-dev is not necessary). In development environment, libibverbs-dev provides header files and libibverbs.so as a symbol link.

Thanks for your feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants