Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include directly dependent header #1993

Merged
merged 1 commit into from
Nov 15, 2022
Merged

Include directly dependent header #1993

merged 1 commit into from
Nov 15, 2022

Conversation

372046933
Copy link
Contributor

What problem does this PR solve?

Issue Number:

Problem Summary:

What is changed and the side effects?

Changed:

Side effects:

  • Performance effects(性能影响):

  • Breaking backward compatibility(向后兼容性):


Check List:

  • Please make sure your changes are compilable(请确保你的更改可以通过编译).
  • When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
  • Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

bool SupportedByRdma(std::string protocol); use std::string but forgets to #include <string>
See https://github.com/apache/incubator-brpc/blob/7998e68b89164d806933a8deddaa0b8b8f125f1b/src/brpc/rdma/rdma_helper.h#L77

Compile error like this can happen

external/brpc/src/brpc/rdma/rdma_helper.h:77:27: error: ‘string’ is not a member of ‘std’
   77 | bool SupportedByRdma(std::string protocol);
      |                           ^~~~~~
external/brpc/src/brpc/rdma/rdma_helper.h:24:1: note: ‘std::string’ is defined in header ‘<string>; did you forget to ‘#include <string>’?
   23 | #include <infiniband/verbs.h>
  +++ |+#include <string>
   24 | 

@wwbmmm wwbmmm merged commit 3d90221 into apache:master Nov 15, 2022
@372046933 372046933 deleted the fix_header branch November 15, 2022 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants