Optimize parallel channel request map method #2057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gydong
reviewed
Dec 28, 2022
src/brpc/parallel_channel.h
Outdated
| virtual SubCall Map(int channel_index/*starting from 0*/, | ||
| const google::protobuf::MethodDescriptor* method, | ||
| const google::protobuf::Message* request, | ||
| google::protobuf::Message* response) = 0; |
There was a problem hiding this comment.
这个弃用版本还是纯虚函数的话，会不会不利于实现侧向新接口函数迁移？
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.