Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add some functions of PtrContainer #2107

Merged
merged 2 commits into from
Feb 6, 2023
Merged

Conversation

chenBright
Copy link
Contributor

What problem does this PR solve?

Issue Number:

Problem Summary:

What is changed and the side effects?

Changed: 重载了一些函数,期望PtrContainer可以像std::unique_ptr一样可以直接操作指针。

Side effects:

  • Performance effects(性能影响):

  • Breaking backward compatibility(向后兼容性):


Check List:

  • Please make sure your changes are compilable(请确保你的更改可以通过编译).
  • When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
  • Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

@wwbmmm
Copy link
Contributor

wwbmmm commented Feb 1, 2023

编译失败了

@chenBright
Copy link
Contributor Author

编译失败了

@wwbmmm 应该好了

@wwbmmm
Copy link
Contributor

wwbmmm commented Feb 2, 2023

LGTM

1 similar comment
@cdjingit
Copy link
Contributor

cdjingit commented Feb 2, 2023

LGTM

@wwbmmm wwbmmm merged commit 7f1a8ed into apache:master Feb 6, 2023
@chenBright chenBright deleted the PtrContainer branch February 6, 2023 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants