-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Periodic ns quit #2123
Periodic ns quit #2123
Conversation
dea698d
to
ef48e53
Compare
LGTM |
1 similar comment
LGTM |
@wwbmmm @serverglen
这个pr可能需要回退一下或者重新提一个pr将ConsulNamingService改回去。 |
要不重新提一个pr把ConsulNamingService改回去? |
好的,我今天改一下。 |
* Fix periodic ns thread can not quit * Abstract ConsulNamingService into a PeriodicNamingService * Quit periodic ns when bthread is stopped
* Fix periodic ns thread can not quit * Abstract ConsulNamingService into a PeriodicNamingService * Quit periodic ns when bthread is stopped
What problem does this PR solve?
Issue Number: #584
Problem Summary: 继承自PeriodicNamingService的ns,例如DiscoveryNamingService、NacosNamingService、RemoteFileNamingService,在GetServers中通过rpc拉取节点的时候,NamingServiceThread析构调用bthread_stop并不能中断CallMethod,CallMethod只是被唤醒了一下,而且将interrupted置回为false,CallMethod依然会等到rpc结束。但是这时候bthread_usleep已经不能感知到bthread_interrupt而退出了。
What is changed and the side effects?
Changed:
Side effects:
Performance effects(性能影响):
Breaking backward compatibility(向后兼容性):
Check List: