naming timer sampling and worker threads #2136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wwbmmm
reviewed
Feb 24, 2023
src/bvar/detail/sampler.cpp
Outdated
| @@ -108,6 +109,7 @@ class SamplerCollector : public bvar::Reducer<Sampler*, CombineSampler> { | |||
| void run(); | |||
|
|
|||
| static void* sampling_thread(void* arg) { | |||
| butil::PlatformThread::SetName("brpc_sampling"); | |||
There was a problem hiding this comment.
In addition to the sampling thread, bvar also has a grab thread and two dump threads. (see variable.cpp and collector.cpp) Can you also add names to them?
ehds
force-pushed
the
add_thread_name
branch
from
cc836b1
to
c63edac
Compare
|
brpc/src/brpc/details/usercode_backup_pool.cpp Lines 103 to 106 in d6df0f1 Can you also add name to UserCodeBackupPool? |
done |
|
LGTM |
yanglimingcn
pushed a commit
to yanglimingcn/brpc
that referenced
this pull request
Jun 25, 2023
* naming timer sampling and worker threads * naming colloctor and varaiable * naming usercode backup thread --------- Co-authored-by: DongSheng He <hds@dipeak.com>
yanglimingcn
pushed a commit
to yanglimingcn/brpc
that referenced
this pull request
Oct 31, 2023
* naming timer sampling and worker threads * naming colloctor and varaiable * naming usercode backup thread --------- Co-authored-by: DongSheng He <hds@dipeak.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: #1923
Problem Summary: Naming threads for debugging.
线程命名方式：
brpc开头 +线程用途。其中 worker 线程以 id 作为区分。
What is changed and the side effects?
No
Changed:
Naming sampling, timer and worker threads.
Side effects:
No
No
Check List: