Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bvar add is_hidden #2205

Merged
merged 1 commit into from
Apr 13, 2023
Merged

bvar add is_hidden #2205

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/bvar/variable.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,10 @@ int Variable::expose_impl(const butil::StringPiece& prefix,
return -1;
}

bool Variable::is_hidden() const {
return _name.empty();
}

bool Variable::hide() {
if (_name.empty()) {
return false;
Expand Down
3 changes: 3 additions & 0 deletions src/bvar/variable.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,9 @@ class Variable {
// a variable that is just destructing.
bool hide();

// Check if this variable is is_hidden.
bool is_hidden() const;

// Get exposed name. If this variable is not exposed, the name is empty.
const std::string& name() const { return _name; }

Expand Down
5 changes: 5 additions & 0 deletions test/bvar_variable_unittest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,12 +64,14 @@ class VariableTest : public testing::Test {
TEST_F(VariableTest, status) {
bvar::Status<int> st1;
st1.set_value(9);
ASSERT_TRUE(st1.is_hidden());
#ifdef BAIDU_INTERNAL
boost::any v1;
st1.get_value(&v1);
ASSERT_EQ(9, boost::any_cast<int>(v1));
#endif
ASSERT_EQ(0, st1.expose("var1"));
ASSERT_FALSE(st1.is_hidden());
ASSERT_EQ("9", bvar::Variable::describe_exposed("var1"));
std::vector<std::string> vars;
bvar::Variable::list_exposed(&vars);
Expand All @@ -79,13 +81,16 @@ TEST_F(VariableTest, status) {

bvar::Status<int> st2;
st2.set_value(10);
ASSERT_TRUE(st2.is_hidden());
ASSERT_EQ(-1, st2.expose("var1"));
ASSERT_TRUE(st2.is_hidden());
ASSERT_EQ(1UL, bvar::Variable::count_exposed());
ASSERT_EQ("10", st2.get_description());
ASSERT_EQ("9", bvar::Variable::describe_exposed("var1"));
ASSERT_EQ(1UL, bvar::Variable::count_exposed());

ASSERT_TRUE(st1.hide());
ASSERT_TRUE(st1.is_hidden());
ASSERT_EQ(0UL, bvar::Variable::count_exposed());
ASSERT_EQ("", bvar::Variable::describe_exposed("var1"));
ASSERT_EQ(0, st1.expose("var1"));
Expand Down