Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log function name #2247

Merged
merged 1 commit into from
Jun 4, 2023
Merged

Log function name #2247

merged 1 commit into from
Jun 4, 2023

Conversation

chenBright
Copy link
Contributor

What problem does this PR solve?

Issue Number:

Problem Summary:

打印日志所在函数的函数名，形如：

E0711 15:14:01.830110 12735 server.cpp:752 StartInternal] xxxx

What is changed and the side effects?

Changed:

Side effects:

  • Performance effects(性能影响):

  • Breaking backward compatibility(向后兼容性):

Check List:

  • Please make sure your changes are compilable(请确保你的更改可以通过编译).
  • When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
  • Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

wwbmmm
wwbmmm reviewed May 15, 2023
View reviewed changes
src/butil/logging.cc Outdated Show resolved Hide resolved
src/butil/logging.cc Outdated Show resolved Hide resolved
@chenBright chenBright force-pushed the log_function_name branch from d942707 to bc90f9c Compare May 15, 2023 14:32
@chenBright chenBright force-pushed the log_function_name branch from bc90f9c to 067c806 Compare May 15, 2023 15:16
@wwbmmm
Copy link
Contributor

wwbmmm commented May 16, 2023

LGTM

@chenBright chenBright added the enhancement improvements on existing features label May 16, 2023
@serverglen
Copy link
Contributor

LGTM

@zyearn zyearn merged commit b36ce2c into apache:master Jun 4, 2023
@chenBright chenBright deleted the log_function_name branch June 5, 2023 01:58
yanglimingcn pushed a commit to yanglimingcn/brpc that referenced this pull request Oct 31, 2023
@chenBright
Log function name (apache#2247)
fdb7698
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wwbmmm wwbmmm wwbmmm left review comments

Assignees
No one assigned
Labels
enhancement improvements on existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chenBright @wwbmmm @serverglen @zyearn