Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix compiler optimize thread local variable access on x86_64 #2248

Merged
merged 1 commit into from
Jun 4, 2023
Merged

fix compiler optimize thread local variable access on x86_64 #2248

merged 1 commit into from
Jun 4, 2023

Conversation

adonis0147
Copy link
Contributor

What problem does this PR solve?

Issue Number: #845

Problem Summary:

使用Clang-16去编译BRPC,在x86_64平台上也会出现"sched_to itself"的问题。在Linux x86_64以及macOS x86_64上均能复现。

What is changed and the side effects?

Changed: 在x86_64平台上用Clang编译器的时候禁用thread local变量的优化。

Side effects:

  • Performance effects(性能影响): 使用Clang编译器的时候不采用thread local变量优化。

  • Breaking backward compatibility(向后兼容性): 无


Check List:

  • Please make sure your changes are compilable(请确保你的更改可以通过编译).
  • When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
  • Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

@wwbmmm
Copy link
Contributor

wwbmmm commented May 15, 2023

LGTM

@zyearn zyearn merged commit 1b486c6 into apache:master Jun 4, 2023
@adonis0147 adonis0147 deleted the dev branch June 5, 2023 02:33
yanglimingcn pushed a commit to yanglimingcn/brpc that referenced this pull request Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants