Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix resource leak when there are multiple HCAs #2252

Merged
merged 4 commits into from
May 22, 2023
Merged

Fix resource leak when there are multiple HCAs #2252

merged 4 commits into from
May 22, 2023

Conversation

372046933
Copy link
Contributor

What problem does this PR solve?

When there are multiple HCAs, current implementation defaults to the last device. Previous opened device was not closed.
Issue Number:

Problem Summary:

What is changed and the side effects?

Changed:

Side effects:

  • Performance effects(性能影响):

  • Breaking backward compatibility(向后兼容性):

Check List:

  • Please make sure your changes are compilable(请确保你的更改可以通过编译).
  • When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
  • Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

@Tuvie
Copy link
Contributor

Tuvie commented May 20, 2023

LGTM

@372046933
Copy link
Contributor Author

@Tuvie Can this PR be merged?

@Tuvie Tuvie merged commit f4c19e3 into apache:master May 22, 2023
@372046933 372046933 deleted the rdma_opt branch May 22, 2023 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tuvie Tuvie Tuvie left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@372046933 @Tuvie