-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix thrift version gt 0.13.0 #2257
Conversation
4cc5992
to
57024f8
Compare
seems also need to address other two compile methods |
1b33526
to
03c8001
Compare
No so sure if I need to get bazel compatible for thrift >= 0.13, seems there is no enough doc about how to build by bazel... |
The bazel build use thrift 0.15.0 and CI is success. It seems that bazel build already supports thrift > 0.13.0 ? |
@wwbmmm so already compatible. |
This PR has conflicts with master, please resolve @ZjuYTW |
Signed-off-by: wangyitao <wangyitao999@outlook.com>
Signed-off-by: wangyitao <wangyitao999@outlook.com>
03c8001
to
8f08146
Compare
LGTM |
maybe we can merge it? @wwbmmm |
What problem does this PR solve?
Issue Number: #1328
Problem Summary:
When using thrift version greater than 0.13.0, brpc can't compile correctly due to deprecate of boost.
What is changed and the side effects?
Changed:
Now compile logic works as follow:
For version < 0.11, set THRIFT_VERSION_LOWER_THAN_0_11_0 in cmake and using boost
For 0.11 <= version < 0.13, THRIFT_STDCXX_H is set inside thrift/stdcxx.h and use apache::thrift::stdcxx
For later, just use std
Side effects:
No
No, later version of thrift use std as well.
Check List: