Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate content type #2319

Merged
merged 1 commit into from
Aug 9, 2023
Merged

Conversation

chenBright
Copy link
Contributor

What problem does this PR solve?

Issue Number:

Problem Summary:

if (!h->content_type().empty()) {
os << "Content-Type: " << h->content_type()
<< BRPC_CRLF;
}
for (HttpHeader::HeaderIterator it = h->HeaderBegin();
it != h->HeaderEnd(); ++it) {
os << it->first << ": " << it->second << BRPC_CRLF;
}

如果一次http请求中,同时调用了set_content_typeSetHeader("Content-Type"),那么MakeRawHttpRequest后的http包中会有两个Content-Type header。

What is changed and the side effects?

Changed:

Side effects:

  • Performance effects(性能影响):

  • Breaking backward compatibility(向后兼容性):


Check List:

  • Please make sure your changes are compilable(请确保你的更改可以通过编译).
  • When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
  • Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

src/brpc/http_header.cpp Outdated Show resolved Hide resolved
@chenBright chenBright added the bug the code does not work as expected label Jul 22, 2023
@wwbmmm
Copy link
Contributor

wwbmmm commented Jul 26, 2023

LGTM

@serverglen serverglen merged commit 51783f1 into apache:master Aug 9, 2023
@chenBright chenBright deleted the fix_content_type branch August 9, 2023 02:51
yanglimingcn pushed a commit to yanglimingcn/brpc that referenced this pull request Oct 31, 2023
yanglimingcn pushed a commit to yanglimingcn/brpc that referenced this pull request Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug the code does not work as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants