fix huge rdma_recv_block_type no effect issue.
#2326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tuvie
reviewed
Jul 24, 2023
src/brpc/rdma/rdma_endpoint.cpp
Outdated
| static const size_t HELLO_MSG_LEN_MAX = 4096; | ||
| static const size_t ACK_MSG_LEN = 4; | ||
| static uint16_t g_rdma_hello_msg_len = 38; // In Byte | ||
| static uint16_t g_rdma_hello_msg_len = 40; // In Byte | ||
| static uint16_t g_rdma_hello_version = 1; |
There was a problem hiding this comment.
Since we modify the hello message format, we should change the hello version.
legionxiong
changed the title
huge rdma_recv_block_type unavailable issue.huge rdma_recv_block_type no effect issue.
wwbmmm
reviewed
Aug 16, 2023
test/brpc_rdma_unittest.cpp
Outdated
| @@ -203,7 +203,7 @@ TEST_F(RdmaTest, client_hello_msg_invalid_magic_str) { | |||
| Socket* s = GetSocketFromServer(0); | |||
| ASSERT_EQ(rdma::RdmaEndpoint::UNINIT, s->_rdma_ep->_state); | |||
|
|
|||
| uint8_t data[38]; | |||
| uint8_t data[40]; | |||
There was a problem hiding this comment.
use named constant instead of 40
It has no effect for `huge` type of recv_block_size which is as large as 2^21, because the `block_size` variable is defined as type `uint16_t`, its maximum value is 2^16. So, change the type of `block_size` to `uint32_t` with relevant updates. Signed-off-by: Lijin Xiong <lijin.xiong@zstack.io>
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has no effect for
hugetype of recv_block_sizewhich is as large as 2^21, because the
block_sizevariable is defined as type
uint16_t, its maximumvalue is 2^16. So, change the type of
block_sizeto
uint32_twith relevant updates.What problem does this PR solve?
Issue Number:
Problem Summary:
What is changed and the side effects?
Changed:
Side effects:
Performance effects(性能影响):
Breaking backward compatibility(向后兼容性):
Check List: